Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct mime output - fix #96 #97

Merged
merged 1 commit into from
Jun 16, 2017
Merged

Correct mime output - fix #96 #97

merged 1 commit into from
Jun 16, 2017

Conversation

mbhopton
Copy link
Contributor

@mbhopton mbhopton commented Mar 3, 2017

Correct "if mime else None" in accordance with PEP8:

Also, beware of writing if x when you really mean if x is not None -- e.g. when testing whether a variable or argument that defaults to None was set to some other value. The other value might have a type (such as a container) that could be false in a boolean context!

@mbhopton
Correct mime output - fix openpreserve#96
44b239b 
Correct "if mime else None" in accordance with PEP8
sevein
sevein approved these changes Mar 3, 2017
View reviewed changes
Copy link
Contributor

@sevein sevein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbhopton thanks, good catch. That was actually my fault, I accidentally introduced the truth value test as part of a code cleanup.

@jhsimpson jhsimpson added this to the 1.3.6 milestone Jun 16, 2017
@jhsimpson jhsimpson merged commit 0611a97 into openpreserve:master Jun 16, 2017
@mbhopton mbhopton deleted the fix-mime branch June 16, 2017 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sevein sevein sevein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.6
Development

Successfully merging this pull request may close these issues.
3 participants
@mbhopton @sevein @jhsimpson